Refactor members pagination from HAML to Vue
📖 What does this MR do?
Related to #327648 (closed) part of &5616
Currently the group/project member pages are composed of 4 separate Vue applications that use Bootstrap tabs. We would like to move these into one Vue app so we can use GlTabs
and move towards deprecating Bootstrap tabs. As a step towards doing this we need to refactor the pagination that is currently rendered with HAML to Vue.
💻 Local testing
Project members
- Create a project
- Navigate to "Project" -> "Members"
- Use the form to add 5 users
- Change app/controllers/projects/project_members_controller.rb#L31 to:
@project_members = present_members(project_members.non_invite.page(params[:page]).per(2))
Group members
- Create a group
- Navigate to "Group" -> "Members"
- Use the from to add 5 users
- Use the form to add 5 invited members
- In the
GitLab member or Email address
enter an email that a user does not already own - Click
Invite "example@test.com" by email
- In the
- Change app/controllers/groups/group_members_controller.rb#L8 to
2
📷 Screenshots
View | Before | After |
---|---|---|
Group members | ||
Group invites | ||
Project members |
🚦 Does this MR meet the acceptance criteria?
Conformity
-
📋 Does this MR need a changelog?-
I have included a changelog entry. -
I have not included a changelog entry because no visual changes.
-
- [-] Documentation (if required)
-
Code review guidelines -
Merge request performance guidelines -
Style guides - [-] Database guides
-
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers - [-] Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
- [-] Label as security and @ mention
@gitlab-com/gl-security/appsec
- [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
- [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Peter Hegman