Skip to content

Remove credentials inventory GPG keys feature flag [RUN ALL RSPEC] [RUN AS-IF-FOSS]

Robert Hunt requested to merge remove-gpg-keys-feature-flag into master

What does this MR do?

This MR removes the :credential_inventory_gpg_keys feature flag and associated code. The feature flag was defaulted to on on GitLab.com and in %13.11 without issue.

Screenshots (strongly suggested)

image

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

  1. Visit [HOST]/admin/credentials?filter=gpg_keys
  2. Confirm that the tab is shown and GPG keys are displayed (you may need to add some to users if none have been created yet)

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Robert Hunt

Merge request reports