Revise expectation on explicit coordination in feature flag rollout template
What does this MR do?
This change addresses some questions that came up after !39975 (merged) was merged.
We have been explicitly working towards removing approvals from EOC !58480 (merged) in favour of safer incremental rollouts !56964 (merged).
This change makes these specific changes:
- Make it clear that we expect an incremental rollout by placing that in the checklist
- Eliminate the top-level checklist so that we have a single one to follow
- Remove the expectation to coordinate with EOC and release managers on slack
There may be some other areas we want to iterate on, but I think this should address the most pressing issues.
We'll want to get this merged ASAP, since feature flag issues tend to live a while, and we see a trail of approval requests on the EOC even weeks after changing the template.
Screenshots (strongly suggested)
Does this MR meet the acceptance criteria?
Conformity
-
📋 Does this MR need a changelog?-
I have included a changelog entry. -
I have not included a changelog entry because _____.
-
-
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Edited by Igor