Skip to content

Perform gitlab-ci-token authentication always using primary

Kamil Trzciński requested to merge perform-ci-build-auth-always-on-primary into master

What does this MR do?

Improves: https://gitlab.com/gitlab-org/gitlab-ce/issues/46037 making gitlab-ci-token auth requests to always use primary.

This is targeted change, that switches to primary only when gitlab-ci-token login is used, and for very short period of time.

This aids against high replication lag, and builds having OTP token generated.

Does this MR meet the acceptance criteria?

  • Changelog entry added, if necessary
  • Tests added for this feature/bug
  • Conform by the code review guidelines
    • Has been reviewed by a Backend maintainer
    • Has been reviewed by a Database specialist
  • EE specific content should be in the top level /ee folder
  • Conform by the merge request performance guides
  • Conform by the style guides
  • If you have multiple commits, please combine them into a few logically organized commits by squashing them
  • End-to-end tests pass (package-qa manual pipeline job)

What are the relevant issue numbers?

Related to https://gitlab.com/gitlab-org/gitlab-ce/issues/46037

Edited by Yorick Peterse

Merge request reports