Skip to content

Remove sentry_processors_before_send feature flag [RUN ALL RSPEC] [RUN AS-IF-FOSS]

Sean McGivern requested to merge remove-sentry-processors-flag into master

What does this MR do?

This flag enabled us to switch between two modes of operation for processing Sentry events before we send them (for GitLab-internal errors, not our Sentry integration):

  1. Use a processors array, as in the current version of the gem.
  2. Manually chain these processors in before_send, which we'll need to do when we upgrade.

We've been running with the flag enabled - which does option 2 - for a while now with no ill effects, so we can simplify the code and specs and just use that going forwards.

These example events (after enabling the flag in the relevant environments) have the correct results:

  1. https://sentry.gitlab.net/gitlab/staginggitlabcom/issues/2576578/?query=is%3Aunresolved
  2. https://sentry.gitlab.net/gitlab/staginggitlabcom/issues/1689475/?query=is%3Aunresolved
  3. https://sentry.gitlab.net/gitlab/gitlabcom/issues/2576748/?query=is%3Aunresolved

We can see that the argument filtering is in place and that the grpc_debug_error_string field is set when appropriate.

For gitlab-com/gl-infra/scalability#849.

Edited by 🤖 GitLab Bot 🤖

Merge request reports