Skip to content

Use declarative_policy gem

Alex Kalderimis requested to merge ajk-declarative-policy-gem into master

What does this MR do?

This completes the process of open-sourcing the declarative policy library (#325463 (closed)), by replacing the code from this repository with the extracted gem.

Closes #325463 (closed)

Closes https://gitlab.com/gitlab-org/declarative-policy/-/issues/7

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Tests are removed that have been moved to the gem. Existing policy specs should all pass.

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

This makes a fundamental change to the way we handle authorization. It definitely requires a security review from @gitlab-com/gl-security/appsec

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Alex Kalderimis

Merge request reports