Skip to content

Allow skipping before parsing .gitlab-ci.yml

Matt Kornfield requested to merge mckornfield/gitlab:dont-parse-on-skip into master

What does this MR do?

Fixes #235855 (closed)

Pushing with the skip option or adding [skip ci] will fail if the .gitlab-ci.yml is invalid or cannot be parsed due to permission issues. This moves the skip stage earlier to prevent an invalid pipeline from spawning.

The risks are very low, in that skipping CI is already indicates opting out of running various pipelines

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Matt Kornfield

Merge request reports