Resolve Discussion Checkbox Doesn't Resolve the Discussion
What does this MR do?
Intended to show a bug that I can't replicate on local, but has been in production for a few weeks?
My anecdotal experience is:
- Respond to a review comment and check the
Resolve Discussion
checkbox - Add the comment to a Review
- Submit the review
- The discussion is not resolved
Submitting a single comment - outside of a review - resolves the discussion properly (I believe).
Screenshots (strongly suggested)
Does this MR meet the acceptance criteria?
Conformity
-
📋 Does this MR need a changelog?-
I have included a changelog entry. -
I have not included a changelog entry because _____.
-
-
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team