Skip to content

Remove redundant index on epics

Steve Abrams requested to merge remove_epics_index into master

🔍 What does this MR do?

The epics table has the following two indexes:

"index_epics_on_group_id_and_iid" UNIQUE, btree (group_id, iid)
"index_epics_on_group_id" btree (group_id)

index_epics_on_group_id is made redundant by the first index.

This MR removes index_epics_on_group_id, freeing up some space.

🐘 Database

→ be rake db:migrate:redo
== 20210415144538 RemoveIndexEpicsOnGroupIdFromEpics: reverting ===============
-- transaction_open?()
   -> 0.0000s
-- index_exists?(:epics, :group_id, {:name=>"index_epics_on_group_id", :algorithm=>:concurrently})
   -> 0.0135s
-- execute("SET statement_timeout TO 0")
   -> 0.0014s
-- add_index(:epics, :group_id, {:name=>"index_epics_on_group_id", :algorithm=>:concurrently})
   -> 0.0130s
-- execute("RESET ALL")
   -> 0.0016s
== 20210415144538 RemoveIndexEpicsOnGroupIdFromEpics: reverted (0.0315s) ======

== 20210415144538 RemoveIndexEpicsOnGroupIdFromEpics: migrating ===============
-- transaction_open?()
   -> 0.0000s
-- indexes(:epics)
   -> 0.0123s
-- execute("SET statement_timeout TO 0")
   -> 0.0010s
-- remove_index(:epics, {:algorithm=>:concurrently, :name=>"index_epics_on_group_id"})
   -> 0.0057s
-- execute("RESET ALL")
   -> 0.0019s
== 20210415144538 RemoveIndexEpicsOnGroupIdFromEpics: migrated (0.0226s) ======

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Steve Abrams

Merge request reports