Skip to content

Fix ProjectPipelineStatus cache specs flakiness

Dmitry Gruzd requested to merge fix-pipeline-cache-flakiness into master

What does this MR do?

While working on #227383 (closed) I noticed that 2 spec examples are extremely inconsistent if you run them more than once. Also, I noticed that running gdk restart allows them to pass one time.

bin/rspec spec/services/ci/expire_pipeline_cache_service_spec.rb:52 spec/services/ci/destroy_pipeline_service_spec.rb:20

It happens because we use redis caching and never clean the caching key since we use the tag use_clean_rails_memory_store_caching instead of use_clean_rails_redis_caching. This MR fixes the issue and these specs start to pass every time.

Relevant code:

Screenshots (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Dmitry Gruzd

Merge request reports