Skip to content

Improve template of conflicts app

Lukas 'ai-pi' Eipert requested to merge 321090-leipert-gitlab-ui into master

What does this MR do?

This moves (almost) all buttons to GitLab UI and uses the correct styling: confirm over success, selected over 'active'.

We are also moving the HTML around a little in order to align with our button guidelines (primary button should be next to cancel button) and keep the DOM simpler, removing redundant <div> and <template> elements. Also removed a few "useless" classes in favor of our utility classes.

Unfortunately I wasn't able to make the GitLab UI Form elements work properly with the textarea.

Screenshots (strongly suggested)

Before After
Screenshot_2021-04-14_Merge_Conflicts___Update_README___1___Merge_requests___Administrator_test-conflicts_1_ Screenshot_2021-04-14_Merge_Conflicts___Update_README___1___Merge_requests___Administrator_test-conflicts_3_
Screenshot_2021-04-14_Merge_Conflicts___Update_README___1___Merge_requests___Administrator_test-conflicts Screenshot_2021-04-14_Merge_Conflicts___Update_README___1___Merge_requests___Administrator_test-conflicts_2_
conflicts-app-before conflicts-app-after

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #321090 (closed)

Edited by Lukas 'ai-pi' Eipert

Merge request reports