Return 403 when job is deleted
What does this MR do?
When a job doesn't exist anymore and GitLab Runner sends a trace update send a 403 Forbidden instead of 404 Not Found so that GitLab Runner can cancel the job. This is a common use case when the Build is deleted from the database and GitLab Runner keeps running the jobs until timeout.
Does this MR meet the acceptance criteria?
Conformity
-
📋 Does this MR need a changelog?-
I have included a changelog entry. -
I have not included a changelog entry because _____.
-
-
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Related to https://gitlab.com/gitlab-org/gitlab-runner/-/issues/27765
Edited by Steve Xuereb