Skip to content

Ensure the pipeline's iid is set before skipping [RUN ALL RSPEC] [RUN AS-IF-FOSS]

Marc Shaw requested to merge ensure_project_iid_before_skip_pipeline into master

What does this MR do?

We need ensure_project_iid to run without any parent transaction, otherwise the InternalId table for that scope, in our case project, will be locked for the entire transaction. Therefore we need to run ensure_project_iid before the skip! call which sets the project iid in a transaction.

Screenshots (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Kamil Trzciński

Merge request reports