Ensure the pipeline's iid is set before saving[RUN ALL RSPEC] [RUN AS-IF-FOSS]
What does this MR do?
We need ensure_project_iid to run without any parent transaction, otherwise the InternalId table for that scope, in our case project, will be locked for the entire transaction. Therefore we need to run ensure_project_iid before the save! call which sets the project iid in a transaction.
Describe in detail what your merge request does and why.
Are there any risks involved with the proposed change? What additional test coverage is introduced to offset the risk?
Please keep this description up-to-date with any discussion that takes place so that reviewers can understand your intent. This is especially important if they didn't participate in the discussion.
-->
Screenshots (strongly suggested)
Does this MR meet the acceptance criteria?
Conformity
-
📋 Does this MR need a changelog?-
I have included a changelog entry. -
I have not included a changelog entry because _____.
-
-
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team