Skip to content

Add method name to Gitaly DeadlineExceeded errors

James Edwards-Jones requested to merge jej/gitaly-deadline-errors-include-method-name into master

What

Includes more context when re-raising a Gitaly erorrs, such as for the DeadlineExceeded timeout.

Are there points in the code the reviewer needs to double check?

Is this also suitable for other types of error?

Why was this MR needed?

Lots of errors which look the same on the surface making it hard to diagnose and discuss.

See https://gitlab.com/gitlab-org/gitlab-ce/issues/43985 and related issues

Does this MR meet the acceptance criteria?

  • Changelog entry added, if necessary
  • Tests added for this feature/bug
  • Conform by the code review guidelines
    • Has been reviewed by a Backend maintainer
  • End-to-end tests pass (package-qa manual pipeline job)

Merge request reports