Remove feature flag `use_marker_ranges` [RUN ALL RSPEC] [RUN AS-IF-FOSS]
What does this MR do?
Contributes to #324638
Screenshots (strongly suggested)
Does this MR meet the acceptance criteria?
Conformity
-
Does this MR need a changelog?-
I have included a changelog entry. -
I have not included a changelog entry because _____.
-
-
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Merge request reports
Activity
added feature flag label
added backend label
1 --- 2 title: Remove feature flag 3 merge_request: See the changelog documentation.
Generated by
Danger
2 Warnings Please add a merge request type to this merge request. This merge request does not refer to an existing milestone. 1 Message You're adding or removing a feature flag, your MR title needs to include [RUN ALL RSPEC] [RUN AS-IF-FOSS]
(we may have updated it automatically for you and started a new MR pipeline) to ensure everything is covered.Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
Category Reviewer Maintainer backend Vladlena Shumilo ( @vshumilo
) (UTC-5, 10 hours behind@vyaklushin
)Mark Chao ( @lulalala
) (UTC+8, 3 hours ahead of@vyaklushin
)If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerEdited by 🤖 GitLab Bot 🤖added 359 commits
-
2620ea53...e5dfb288 - 358 commits from branch
master
- 99859d89 - Remove feature flag `use_marker_ranges`
-
2620ea53...e5dfb288 - 358 commits from branch
Setting label groupsource code based on
@vyaklushin
's group.added groupsource code label
Setting label(s) Category:Source Code Management devopscreate sectiondev based on groupsource code.
added Category:Source Code Management devopscreate sectiondev labels
@vyaklushin another older MR - can this be closed or merged?
@vyaklushin can this be closed or merged?
added pipeline:run-all-rspec pipeline:run-as-if-foss labels