Skip to content

Fix updating value stream record without stages

Adam Hegyi requested to merge vsa-fix-update-empty-vsa into master

What does this MR do?

This MR fixes a bug when updating value streams with no associated stages. This can happen if the value stream was created before 13.9.

How to reproduce it:

  1. Make sure you're on ultimate
  2. Go to a group and record the id
  3. In rails console create a value stream: Group.find(id).value_streams.create(name: 'test')
  4. Go to the Group -> Analytics -> Value Stream page
  5. Select the test value stream on the top right dropdown and click edit
  6. Add a new stage on the bottom and try to save it.

Screenshots (strongly suggested)

image

Video: https://gitlab.slack.com/files/UH62Q221E/F01TKJBKJTZ/value_stream.mp4

Thanks @mvanremmerden for reporting it!

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Adam Hegyi

Merge request reports