Skip to content

Obtain pipeline validation service token from config not ENV

Craig Miskell requested to merge validation-service-token-to-config into master

What does this MR do?

We don't have any other secrets sourced from environment vars currently so it seems to me we shouldn't start doing that now. It also complicates or confuses the helmcharts configuration (and omnibus too) when we have pre-existing mechanisms/paths.

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Thong Kuah

Merge request reports