Remove the global default branch feature flag [RUN ALL RSPEC] [RUN AS-IF-FOSS]
What does this MR do?
Removes the no-longer-needed global_default_branch_name feature flag.
This has been on by default for several releases now and only hides the configuration screen; it doesn't actually prevent the feature from taking effect. Since we're now looking to configure the default branch to main automatically for new self-managed installations in !56977 (closed) , keeping the feature flag can lead to odd situations where the value is configured, but not configurable.
People who don't want to use the feature can leave the box blank, or (if they can find it) clear it out, so I don't see any value to keeping the FF for several more releases.
Does this MR meet the acceptance criteria?
Conformity
-
📋 Does this MR need a changelog?-
I have included a changelog entry
-
-
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Related to #325163