Add ci template contribution instructions

What does this MR do?

Closes #287805 (closed)

Screenshots (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

• Does this MR need a changelog?
  • I have included a changelog entry.
  • I have not included a changelog entry because _____.
• Documentation (if required)
• Code review guidelines
• Merge request performance guidelines
• Style guides
• Database guides
• Separation of EE specific content

Availability and Testing

• Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process.
• Tested in all supported browsers
• Informed Infrastructure department of a default or new setting change, if applicable per definition of done

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

• Label as security and @ mention @gitlab-com/gl-security/appsec
• The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
• Security reports checked/validated by a reviewer from the AppSec team

added 1 commit

• c0b4b68b - Add contribution section to all CI/CD templates

Compare with previous version

changed the description

mentioned in issue #287805 (closed)

	2 Warnings
	Please add a merge request type to this merge request.
	You've made some app changes, but didn't add any tests. That's OK as long as you're refactoring existing code, but please consider adding any of the tooling, ~"tooling::pipelines", ~"tooling::workflow", documentation, QA labels.

	2 Messages
	CHANGELOG missing: If you want to create a changelog entry for GitLab FOSS, add the Changelog trailer to the commit message you want to add to the changelog. If you want to create a changelog entry for GitLab EE, also add the EE: true trailer to your commit message. If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
	This merge request adds or changes files that require a review from the CI/CD Templates maintainers.

This merge request requires a CI/CD Template review. To make sure these changes are reviewed, take the following steps:

1. Ensure the merge request has the citemplates label. If the merge request modifies CI/CD Template files, Danger will do this for you.
2. Prepare your MR for a CI/CD Template review according to the template development guide.
3. Assign and @ mention the CI/CD Template reviewer suggested by Reviewer Roulette.

The following files require a review from the CI/CD Templates maintainers:

• lib/gitlab/ci/templates/5-Minute-Production-App.gitlab-ci.yml
• lib/gitlab/ci/templates/AWS/CF-Provision-and-Deploy-EC2.gitlab-ci.yml
• lib/gitlab/ci/templates/AWS/Deploy-ECS.gitlab-ci.yml
• lib/gitlab/ci/templates/Android-Fastlane.gitlab-ci.yml
• lib/gitlab/ci/templates/Android.gitlab-ci.yml
• lib/gitlab/ci/templates/Auto-DevOps.gitlab-ci.yml
• lib/gitlab/ci/templates/Bash.gitlab-ci.yml
• lib/gitlab/ci/templates/C++.gitlab-ci.yml
• lib/gitlab/ci/templates/Chef.gitlab-ci.yml
• lib/gitlab/ci/templates/Clojure.gitlab-ci.yml
• lib/gitlab/ci/templates/Composer.gitlab-ci.yml
• lib/gitlab/ci/templates/Crystal.gitlab-ci.yml
• lib/gitlab/ci/templates/Dart.gitlab-ci.yml
• lib/gitlab/ci/templates/Django.gitlab-ci.yml
• lib/gitlab/ci/templates/Docker.gitlab-ci.yml
• lib/gitlab/ci/templates/Elixir.gitlab-ci.yml
• lib/gitlab/ci/templates/Flutter.gitlab-ci.yml
• lib/gitlab/ci/templates/Getting-Started.gitlab-ci.yml
• lib/gitlab/ci/templates/Go.gitlab-ci.yml
• lib/gitlab/ci/templates/Gradle.gitlab-ci.yml
• lib/gitlab/ci/templates/Grails.gitlab-ci.yml
• lib/gitlab/ci/templates/Hello-World.gitlab-ci.yml
• lib/gitlab/ci/templates/Julia.gitlab-ci.yml
• lib/gitlab/ci/templates/LaTeX.gitlab-ci.yml
• lib/gitlab/ci/templates/Laravel.gitlab-ci.yml
• lib/gitlab/ci/templates/Maven.gitlab-ci.yml
• lib/gitlab/ci/templates/Mono.gitlab-ci.yml
• lib/gitlab/ci/templates/Nodejs.gitlab-ci.yml
• lib/gitlab/ci/templates/OpenShift.gitlab-ci.yml
• lib/gitlab/ci/templates/PHP.gitlab-ci.yml
• lib/gitlab/ci/templates/Packer.gitlab-ci.yml
• lib/gitlab/ci/templates/Pages/Brunch.gitlab-ci.yml
• lib/gitlab/ci/templates/Pages/Doxygen.gitlab-ci.yml
• lib/gitlab/ci/templates/Pages/Gatsby.gitlab-ci.yml
• lib/gitlab/ci/templates/Pages/HTML.gitlab-ci.yml
• lib/gitlab/ci/templates/Pages/Harp.gitlab-ci.yml
• lib/gitlab/ci/templates/Pages/Hexo.gitlab-ci.yml
• lib/gitlab/ci/templates/Pages/Hugo.gitlab-ci.yml
• lib/gitlab/ci/templates/Pages/Hyde.gitlab-ci.yml
• lib/gitlab/ci/templates/Pages/JBake.gitlab-ci.yml
• lib/gitlab/ci/templates/Pages/Jekyll.gitlab-ci.yml
• lib/gitlab/ci/templates/Pages/Jigsaw.gitlab-ci.yml
• lib/gitlab/ci/templates/Pages/Lektor.gitlab-ci.yml
• lib/gitlab/ci/templates/Pages/Metalsmith.gitlab-ci.yml
• lib/gitlab/ci/templates/Pages/Middleman.gitlab-ci.yml
• lib/gitlab/ci/templates/Pages/Nanoc.gitlab-ci.yml
• lib/gitlab/ci/templates/Pages/Octopress.gitlab-ci.yml
• lib/gitlab/ci/templates/Pages/Pelican.gitlab-ci.yml
• lib/gitlab/ci/templates/Pages/SwaggerUI.gitlab-ci.yml
• lib/gitlab/ci/templates/Python.gitlab-ci.yml
• lib/gitlab/ci/templates/Ruby.gitlab-ci.yml
• lib/gitlab/ci/templates/Rust.gitlab-ci.yml
• lib/gitlab/ci/templates/Scala.gitlab-ci.yml
• lib/gitlab/ci/templates/Security/API-Fuzzing.gitlab-ci.yml
• lib/gitlab/ci/templates/Security/API-Fuzzing.latest.gitlab-ci.yml
• lib/gitlab/ci/templates/Security/Container-Scanning.gitlab-ci.yml
• lib/gitlab/ci/templates/Security/Coverage-Fuzzing.gitlab-ci.yml
• lib/gitlab/ci/templates/Security/DAST-API.gitlab-ci.yml
• lib/gitlab/ci/templates/Security/DAST-On-Demand-Scan.gitlab-ci.yml
• lib/gitlab/ci/templates/Security/DAST.gitlab-ci.yml
• lib/gitlab/ci/templates/Security/DAST.latest.gitlab-ci.yml
• lib/gitlab/ci/templates/Security/Dependency-Scanning.gitlab-ci.yml
• lib/gitlab/ci/templates/Security/License-Scanning.gitlab-ci.yml
• lib/gitlab/ci/templates/Security/Secure-Binaries.gitlab-ci.yml
• lib/gitlab/ci/templates/Serverless.gitlab-ci.yml
• lib/gitlab/ci/templates/Swift.gitlab-ci.yml
• lib/gitlab/ci/templates/Terraform.gitlab-ci.yml
• lib/gitlab/ci/templates/Terraform.latest.gitlab-ci.yml
• lib/gitlab/ci/templates/Verify/Accessibility.gitlab-ci.yml
• lib/gitlab/ci/templates/Verify/Browser-Performance.gitlab-ci.yml
• lib/gitlab/ci/templates/Verify/Browser-Performance.latest.gitlab-ci.yml
• lib/gitlab/ci/templates/Verify/FailFast.gitlab-ci.yml
• lib/gitlab/ci/templates/Verify/Load-Performance-Testing.gitlab-ci.yml
• lib/gitlab/ci/templates/Workflows/Branch-Pipelines.gitlab-ci.yml
• lib/gitlab/ci/templates/Workflows/MergeRequest-Pipelines.gitlab-ci.yml
• lib/gitlab/ci/templates/dotNET-Core.yml
• lib/gitlab/ci/templates/dotNET.gitlab-ci.yml
• lib/gitlab/ci/templates/iOS-Fastlane.gitlab-ci.yml
• lib/gitlab/ci/templates/npm.gitlab-ci.yml

Reviewer roulette

Changes that require review have been detected!

Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:

Category	Reviewer	Maintainer
citemplates	Laura Montemayor (@lauraMon) (UTC+2)	Shinya Maeda (@shinya.maeda) (UTC+7)

To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.

To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.

Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.

If needed, you can retry the danger-review job that generated this comment.

Generated by Danger

changed milestone to %13.11

added 1 commit

• 35fdd57d - Fix Verify, Security and Workflow folder template references

Compare with previous version

added 1 commit

• 9dbf1b8e - Fix references for Pages and AWS templates

Compare with previous version

It's a great addition, I think the comment works as is.

cc @dhershkovitch @marcel.amirault

requested review from @marcel.amirault

added Technical Writing twdoing labels

added devopsverify grouppipeline authoring labels

removed review request for @marcel.amirault

added sectionops label

changed milestone to %13.12

added missed:13.11 label

@cheryl.li can we make sure someone will merge this one?

changed milestone to %14.0

added missed:13.12 label

changed milestone to %14.1

added missed:14.0 label

@dhershkovitch @cheryl.li - Thanks for being patient with me but I'm clearly the blocker to this improvement. Can we unassign it from me and get it cleaned up to where it could be mergeable or should I close it?

assigned to @cheryl.li and unassigned @kencjohnston

added 1 commit

• f41658bb - Update comment to reference filepath of each CI Template file

Compare with previous version

marked this merge request as ready

requested review from @marcel.amirault

added workflowin review label

added 1 commit

• 32216e7e - fixed typo with invalid yaml in CI Template

Compare with previous version

added 12244 commits

• 32216e7e...32006887 - 12240 commits from branch master
• 213a52eb - Add contribution section to all CI/CD templates
• e086f223 - Update comment to reference filepath of each CI Template file
• 377a6501 - Standardize contribution note
• 460dd39c - Copy edit contribution note

Compare with previous version

removed review request for @marcel.amirault

assigned to @marcel.amirault

requested review from @shinya.maeda

@cheryl.li @kencjohnston Since it has been a while since this branch was created, it was a quite a ways behind master, and had merge conflicts. I pulled the branch, squashed each of your commits together to fix the danger warning. Then I did a rebase, fixed the conflicts (some templates were dropped in 14.0, others moved, etc...).

After that, I pushed one commit that moved all the comments to the top of every template, so they are all in the exact same place. It also means that templates that had notes now have the notes "closer" to the code of the template (not separated by a contribution note).

Then I pushed one more commit, copy editing all the notes to be similar to my suggestion here: !59023 (diffs, comment 550273055)

So, the pipeline likes us, and it's off to @shinya.maeda for maintainer review!

mentioned in issue #334661 (closed)

approved this merge request

resolved all threads

enabled an automatic merge when the pipeline for ccca60fd succeeds

merged

mentioned in commit e1d4a322

added workflowstaging label and removed workflowin review label

added workflowcanary label and removed workflowstaging label

added workflowproduction label and removed workflowcanary label

added releasedcandidate label