Skip to content

Add solargraph to development dependencies

Andrejs Cunskis requested to merge development-solargraph-dependency into master

What does this MR do?

Add solargraph as project development dependency.

I believe this could improve usability for people using such IDE's like vscode or atom which rely on ruby language server which provides autocompletion and additional development experience improvements.

While this isn't strictly necessary and could be used with a standalone solargraph installation, having it defined in the project Gemfile allows starting the language server via bundler ensuring that docs are generated for the correct gems.

The gem itself is not required by the project thus it should not warrant any additional testing, though it does introduce some additional transitive dependencies.

Screenshots (strongly suggested)

vscode-solargraph-0.34.1-a63b2ca0626c295d31413d74577b6e56cbdec00f3bbd444d1fb3bea7d5d8885a

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Andrejs Cunskis

Merge request reports