Skip to content

Update runner type indicators in view/edit pages

What does this MR do?

Fix for #327199 (closed)

This MR changes the page title and banner for runner view and edit pages.

In view pages:

  • Update badge appearance with the type of runner (Group, Specific)

In edit pages:

  • Add a new badge with the type of runner (Instance, Group, Specific)
  • Update appearance of the alert and it's copy, that explain the type in more detail

Screenshots (strongly suggested)

In context:

Before After
image Screen_Shot_2021-04-14_at_8.18.36_AM
image Screen_Shot_2021-04-14_at_8.18.45_AM

Copy text has been updated:

Before After
before-shared shared
before-group group
before-specific specific

The same alert and label has been applied to many different pages:

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #327199 (closed)

Edited by Miguel Rincon

Merge request reports