Skip to content

Fix N+1 queries for issues search

Terri Chu requested to merge 230712-fix-n-1-queries-for-issues-search into master

What does this MR do?

Related to #230712 (closed)

  • Add preloading for project.project_feature (as reported by bullet), project.route, project.namespace and project.namespace.route

  • Update spec to remove threshold for the ActiveRecord::QueryRecorder check

Note: even though the spec changes are only in EE, the changes apply to both CE and EE

Screenshots (strongly suggested)

before

image image

after image

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Terri Chu

Merge request reports