Skip to content

Remediate use of "blacklist" in push rule check error

Ben Prescott_ requested to merge bprescott/20210408-denylist into master

What does this MR do?

Remediates use of the term 'blacklist' in the following error:

remote: GitLab: File name changelogs/unreleased/security-disable-exiftool-aiff-djvu.yml was blacklisted by the pattern ^changelogs\/unreleased\/.+$.

Our docs refer to 'prohibited file names' so I've proposed using the verb prohibit rather than verbifying denylist.

File name #{changed_path.path} was prohibited by the denylist pattern #{denylisted_regex}.

related to epic: &3478 Replace use of whitelist with allowlist and blacklist with denylist

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Ben Prescott_

Merge request reports