Fix issue not passing Dast::Profile branch
What does this MR do?
fixes a regression introduced by !56821 (merged).
Why?
dast
on-demand scans will run against the project's default branch rather than the one set in dast_profile
.
the reason this happened is that there are two features that are slightly out of alignment sharing code and i missed this detail when ensuring one of our services supported both features.
Screenshots (strongly suggested)
Maintainer
demonstration that the refs match.
Developer
demonstration that a developer may run a scan on a non-protected ref.
Does this MR meet the acceptance criteria?
Conformity
-
📋 Does this MR need a changelog?-
I have included a changelog entry. -
I have not included a changelog entry because it is a fix for a regression introduced and then fixed in the same release.
-
-
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Edited by Philip Cunningham