Skip to content

Fix member autocomplete sort order

Coung Ngo requested to merge cngo-fix-member-autocomplete-sort into master

What does this MR do?

This MR fixes member autocomplete sort order.

The @ autocomplete sort did not maintain participant priority due to different browsers calling Array sort methods slightly differently. Here we use lodash's sortBy function which is a stable sort, and has the added benefit of simplifying our logic

Screenshots (strongly suggested)

before after
Screenshot_2021-04-06_at_1.27.31_pm Screenshot_2021-04-06_at_1.27.31_pm
Screenshot_2021-04-06_at_1.27.39_pm Screenshot_2021-04-06_at_1.28.33_pm

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Coung Ngo

Merge request reports