Skip to content

Resolve merge request todos asynchronously on update [RUN ALL RSPEC] [RUN AS-IF-FOSS]

Patrick Bajao requested to merge 20827-async-todo-creation-resolution into master

What does this MR do?

This is one of the changes to reduce the number of SQL queries when MergeRequests::UpdateService is called.

The strategy is to delegate todo resolution (marking pending todo as done) to Sidekiq. This way, SQL queries needed for it won't need to run synchronously on update.

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #20827 (closed)

Edited by Patrick Bajao

Merge request reports