Skip to content

Set workhorse_extract_filename_base feature flag to default

Stan Hu requested to merge sh-enable-workhorse-extract-filename-base-default into master

Before this feature flag was enabled, Workhorse would reject any multipart filename that contained a slash (e.g. dist/release.tar.gz), even though GitLab never used the path in determining whether to store the file. With this feature flag enabled, Workhorse extracts the base from this filename so this path is effectively ignored. This allows uploads via the API to work as before the endpoint was accelerated by Workhorse.

Since this feature flag was enabled, the errors have gone away: https://log.gprd.gitlab.net/goto/14ad5d4898a04edf54df03aaf0294e8b

Relates to:

  1. #326379 (closed)
  2. #326350 (closed)
Edited by Stan Hu

Merge request reports