Skip to content

Revert 324246-fix-incorrect-trigger-property-name

Daniel Tian requested to merge revert-92ec12f0 into master

What does this MR do?

<gl-popover> accepts a triggers prop to control how the popover is shown. One component was using trigger="manual", which is incorrect and wasn't doing anything. In a previous MR I changed it to triggers="manual". However, it breaks a Ruby test that expects the incorrect behavior: https://gitlab.com/gitlab-org/gitlab/-/jobs/1145163252. This MR reverts that change to re-break the manual trigger, but lets the test pass.

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Daniel Tian

Merge request reports