Skip to content

Group SAML identities cleaned up when leaving a group

James Edwards-Jones requested to merge jej/group-saml-cleans-up-identity into master

What

Cleans up left over Identity record when a user leaves a group they joined using Group SAML

Why

If a GitLab user was signed in as the wrong user on the identity provider then an incorrect link would have formed. Keeping this link might prevent a user correctly signing in to the group.

Does this MR meet the acceptance criteria?

  • [-] Changelog entry added, if necessary Group SAML is aimed at GitLab.com but not yet enabled there, and is additionally hidden behind a beta cookie.
  • [-] Documentation created/updated
  • [-] API support added
  • Tests added for this feature/bug
  • Conform by the code review guidelines
    • Has been reviewed by a Backend maintainer
  • [-] If paid feature, have we considered GitLab.com plan and how it works for groups and is there a design for promoting it to users who aren't on the correct plan
  • [-] End-to-end tests pass (package-qa manual pipeline job)

What are the relevant issue numbers?

Closes https://gitlab.com/gitlab-org/gitlab-ee/issues/5565

Edited by Mayra Cabrera

Merge request reports