Pass a pseudo Diff File from notes app to noteable discussion component
What does this MR do?
For #300749 (closed)
Allows the noteable discussion component to fill in the file path variable in the suggestion commit message placeholder value.
It does this - primarily - by providing a second source for diff files in this component.
Because the computed diffFile property is now more complex, I've also added tests for it - which cover the original cases and the new return value provided by the props.
| MR | Description |
|---|---|
| !56575 (merged) | This MR ingests the required endpoint into the MR Notes app. |
| !56594 (merged) | This MR actually loads the diffs_metadata.json data and places it into the state for the MR Notes app |
| !57419 (merged) | This MR switches the Diffs app to use the MR Notes app location to fill the placeholder data |
| We're here |
This MR makes changes to enable getting the Diff file information into the Notes app on the Overview tab |
Screenshots (strongly suggested)
| Before | After |
|---|---|
 |
 |
Does this MR meet the acceptance criteria?
Conformity
-
📋 Does this MR need a changelog?-
I have included a changelog entry. -
I have not included a changelog entry because _____.
-
- [-] Documentation (if required)
-
Code review guidelines -
Merge request performance guidelines -
Style guides - [-] Database guides
- [-] Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers - [-] Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
- [-] Label as security and @ mention
@gitlab-com/gl-security/appsec - [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
- [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by André Luís