Add gl-badge for badges in milestone drawer
What does this MR do?
Add gl-badge for badges in milestone drawer
As a part of https://gitlab.com/gitlab-com/marketing/community-relations/contributor-program/hackathon/-/issues/50
Example Page: %Sales Quick Start - May 2020
Screenshots (strongly suggested)
Before | After |
---|---|
![]() |
![]() |
Does this MR meet the acceptance criteria?
Conformity
-
Does this MR need a changelog?-
I have included a changelog entry. -
I have not included a changelog entry because _____.
-
-
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Merge request reports
Activity
Thank you for your contributions to GitLab. We believe that everyone can contribute and contributions like yours are what make GitLab great!
Our Merge Request coaches will ensure your contribution is reviewed in a timely manner.
To bring your merge request to the attention of the relevant team within GitLab, you can ask our bot to label it with a group label. For example, if your merge request changes a project management feature, it can be labelled by commenting
@gitlab-bot label ~"group::project management"
. To find the most relevant group for your change, you can look up the group based on the most relevant product category in the product categories table. Once you have found the group name, type@gitlab-bot label ~group::
, then start to type the group name and select the applicable group label, then submit the comment and the bot will apply the label for you.If after a few days, there's no message from a GitLab team member, feel free to ping
@gitlab-org/coaches
or ask for help by commenting@gitlab-bot help
.These resources may help you to move your Merge Request to the next steps:
This message was generated automatically. You're welcome to improve it.
added Community contribution label
added Hackathon label
This MR will be considered part of the quarterly GitLab Hackathon for a chance to win a prize. Thank you for your contribution!
Can anyone please review this MR
mentioned in issue gitlab-org/quality/triage-reports#2726 (closed)
mentioned in issue gitlab-org/quality/triage-reports#2789 (closed)
added 3462 commits
-
68eb48d6...9d9b902a - 3460 commits from branch
gitlab-org:master
- 2dac0170 - Add gl-badge for badges in milestone drawer
- ecd246e4 - Update gl-badge-milestone-sidebar.yml
-
68eb48d6...9d9b902a - 3460 commits from branch
- Resolved by Olena Horal-Koretska
Thank you for the contribution!
@ohoral can you review this community contribution? Thanks
added component:badge frontend pajamasintegrate + 1 deleted label
assigned to @yo
requested review from @ohoral
mentioned in issue gitlab-org/quality/triage-reports#2792 (closed)
added Category:Design System devopscreate featureenhancement groupecosystem [DEPRECATED] typefeature labels and removed 1 deleted label
changed milestone to %13.12
removed milestone %13.12
enabled an automatic merge when the pipeline for 4a321eb0 succeeds
4 Warnings ecd246e4: The commit subject must contain at least 3 words. For more information, take a look at our Commit message guidelines. featureaddition and featureenhancement merge requests normally have a documentation change. Consider adding a documentation update or confirming the documentation plan with the Technical Writer counterpart.
For more information, see:
- The Handbook page on merge request types.
- The definition of done documentation.
This merge request does not refer to an existing milestone. You've made some app changes, but didn't add any tests.
That's OK as long as you're refactoring existing code,
but please consider adding any of the tooling, ~"tooling::pipelines", ~"tooling::workflow", documentation, QA labels.1 Message We are in the process of rolling out a new workflow for adding changelog entries. This new workflow uses Git commit subjects and Git trailers to generate changelogs. This new approach will soon replace the current YAML based approach. To ease the transition process, we recommend you start using both the old and new approach in parallel. This is not required at this time, but will make it easier to transition to the new approach in the future. To do so, pick the commit that should go in the changelog and add a
Changelog
trailer to it. For example:This is my commit's subject line This is the optional commit body. Changelog: added
The value of the
Changelog
trailer should be one of the following: added, fixed, changed, deprecated, removed, security, performance, other.For more information, take a look at the following resources:
- gitlab-com/gl-infra/delivery#1564 (closed)
- https://docs.gitlab.com/ee/api/repositories.html#generate-changelog-data
If you'd like to see the new approach in action, take a look at the commits in the Omnibus repository.
Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
Category Reviewer Maintainer frontend Alper Akgun ( @a_akgun
) (UTC+3)Jose Ivan Vargas ( @jivanvl
) (UTC-5)If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangermentioned in commit cd021cb0
added workflowstaging label
added workflowcanary label and removed workflowstaging label
changed milestone to %13.12
added workflowproduction label and removed workflowcanary label
mentioned in issue gitlab-org/quality/triage-reports#2894 (closed)
added releasedcandidate label
added 1 deleted label and removed devopscreate label
added devopsmanage label and removed 1 deleted label