Skip to content

Convert has-tooltip on commit page to pajamas

What does this MR do?

  • converts comment button on commits to pajamas design
  • fixes the tooltip properly hiding issue.

How to test locally(gdk)

  • Go to any commit
  • Make a comment
  • refresh the page and button should show as in the screenshots

Screenshots (strongly suggested)

Before (tooltip will not vanish after navigating away unless page is reloaded)

Screen_Shot_2021-03-30_at_12.39.32_PM

Screen_Recording_2021-03-30_at_12.39.46_PM

After

Screen_Shot_2021-03-30_at_2.41.28_PM

Screen_Recording_2021-03-30_at_2.41.36_PM

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #324803

Edited by Alper Akgun

Merge request reports