Skip to content

Fix last diff line not allowing suggestions

Phil Hughes requested to merge ph/fixWeirdSuggestionsState into master

What does this MR do?

Fixes a bug where the last diff line in a diff file would not allow multi line suggestions. Also fixes a bug where single line suggestions would have offset as -1

Screenshots (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Merge request reports