Skip to content

Add `prepend_mod` and a new JH merge requests review guidance

Lin Jen-Shin requested to merge 325800-doc-jh-features into master

What does this MR do?

Add a new JH feature review guidance

Next up

  • Rename prepend_if_ee to prepend_mod_with
  • Rename extend_if_ee to extend_mod_with
  • Rename include_if_ee to include_mod_with
  • Remove ::EE or EE prefix with the module name
  • Remove constant_without_prefix after there's no more prefix passed

Screenshots (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #325800 (closed)

Edited by Lin Jen-Shin

Merge request reports