Skip to content

Support SMTP connection pooling when sending emails

Heinrich Lee Yu requested to merge 230717-add-mail-smtp-pool-gem into master

What does this MR do?

This adds a new ActionMailer delivery method for sending emails using an SMTP connection pool. This is implemented as a gem under vendor/ so that we can easily extract this in the future.

Related to #230717 (closed)

Testing locally

You can test this by following the instructions in config/initializers/smtp_settings.rb.sample

You may need to set action_mailer.perform_deliveries = true because this is set to false in development.

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Heinrich Lee Yu

Merge request reports