Skip to content

Update triggering validation on the alerts integration form

Olena Horal-Koretska requested to merge 325820-update-validation-trigger into master

What does this MR do?

To check navigate to Settings > Operations > Alert integrations expand section or the direct link will be localhost/group/project/-/settings/operations#js-alert-management-settings. Current MR updates validation flow on the form

Previously validation was force-triggered when the user selected integration type on the new integration form - this displayed the error under the field and disabled submit button. I've got UX feedback that users were not happy to see validation errors before they even started filling the form. So the behavior was updated. Submit button now stays enabled. Validation will be triggered on submit.

Screenshots (strongly suggested)

Before After
2021-03-29_14.08.54 2021-03-29_14.09.34

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #325820 (closed)

Edited by Olena Horal-Koretska

Merge request reports