Revise capitalization of "merge request"
Fixes capitalization of "merge request" in files in app/views/projects/merge_requests
.
Related to #233449 (closed)
Merge request reports
Activity
changed milestone to %13.11
added frontend label
1 Warning Please add a merge request type to this merge request. 1 Message CHANGELOG missing: If you want to create a changelog entry for GitLab FOSS, run the following:
bin/changelog -m 57635 "Revise capitalization of "merge request""
If you want to create a changelog entry for GitLab EE, run the following instead:
bin/changelog --ee -m 57635 "Revise capitalization of "merge request""
If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
Category Reviewer Maintainer frontend Nicolas Dular ( @nicolasdular
) (UTC+2, 9 hours ahead of@aqualls
)Jacques Erasmus ( @jerasmus
) (UTC+2, 9 hours ahead of@aqualls
)test Quality for spec/features/*
Mark Lapierre ( @mlapierre
) (UTC+11, 18 hours ahead of@aqualls
)Maintainer review is optional for test Quality for spec/features/*
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerEdited by 🤖 GitLab Bot 🤖Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 08e972e0 and 3ba3f384
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 3.04 MB 3.04 MB - 0.0 % mainChunk 1.87 MB 1.87 MB - 0.0 %
Note: We do not have exact data for 08e972e0. So we have used data from: ea5535ff.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.Please look at the full report for more details
Read more about how this report works.
Generated by
DangerEdited by 🤖 GitLab Bot 🤖- Resolved by Jacques Erasmus
Sending forward to @nicolasdular with a cc to @pedroms to know I'm starting to chip away at this issue.
assigned to @nicolasdular and unassigned @aqualls
added tw-weight5 twfinished labels
1 - page_title _("Merge Conflicts"), "#{@merge_request.title} (#{@merge_request.to_reference}", _("Merge Requests") 1 - page_title _("Merge Conflicts"), "#{@merge_request.title} (#{@merge_request.to_reference}", _("Merge requests") For my personal non-native-speaker curiosity: Why is Merge Conflict capitalised but Merge requests not? 🧐
Edited by Nicolas Dular@nicolasdular Oh, "Merge Conflict" with a capital 'C' is totally wrong, too. You are 100% right to ask about the inconsistency.
I'm trying to keep my changes in scope for #233449 (closed), which is scoped just to the term "merge request." If I let myself fix everything that's mis-capitalized, I won't get finished. So, for now, #233449 (closed) has me working on just "merge request."
MVCs, y'know.
unassigned @nicolasdular
requested review from @jerasmus
mentioned in commit 5eabe70d
assigned to @aqualls
added workflowstaging label
added workflowcanary label and removed workflowstaging label
added workflowproduction label and removed workflowcanary label
added releasedcandidate label