Fix capitalization of "merge requests" in notifications
What does this MR do?
As part of #233449 (closed) - let's fix the bad capitalization of "merge requests" in our notifications:
- Only capitalize the "M" if "merge" is the first word in the sentence or the slug
- Never capitalize the "R"
Screenshots (strongly suggested)
Does this MR meet the acceptance criteria?
Conformity
-
Does this MR need a changelog?-
I have included a changelog entry. -
I have not included a changelog entry because _____.
-
-
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Related to #233449 (closed)
Merge request reports
Activity
changed milestone to %13.11
added frontend label
1 Warning Please add a merge request type to this merge request. 1 Message CHANGELOG missing: If you want to create a changelog entry for GitLab FOSS, run the following:
bin/changelog -m 57632 "Fix capitalization of "merge requests" in notifications"
If you want to create a changelog entry for GitLab EE, run the following instead:
bin/changelog --ee -m 57632 "Fix capitalization of "merge requests" in notifications"
If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
Category Reviewer Maintainer backend Adrien Kohlbecker ( @akohlbecker
) (UTC+2, 9 hours ahead of@aqualls
)Alex Kalderimis ( @alexkalderimis
) (UTC+1, 8 hours ahead of@aqualls
)frontend Angelo Gulina ( @agulina
) (UTC+2, 9 hours ahead of@aqualls
)Olena HK. ( @ohoral
) (UTC+3, 10 hours ahead of@aqualls
)If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerEdited by 🤖 GitLab Bot 🤖Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 193c4447 and 74715fde
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 3.05 MB 3.05 MB - 0.0 % mainChunk 1.87 MB 1.87 MB - 0.0 %
Note: We do not have exact data for 193c4447. So we have used data from: 6c29be7e.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.Please look at the full report for more details
Read more about how this report works.
Generated by
DangerEdited by 🤖 GitLab Bot 🤖added backend label
- Resolved by Dheeraj Joshi
@djadmin I'm having trouble figuring out what I need to fix to make this test (https://gitlab.com/gitlab-org/gitlab/-/jobs/1136766394) pass. I'm trying to fix the capitalization of 'Merge Requests' a little at a time, and I've missed something here. I'm hoping the answer is obvious to someone who actually does FE work.
added 264 commits
-
fee06531...193c4447 - 262 commits from branch
master
- 4542165c - Fix capitalization of "merge requests"
- 74715fde - Fix test for this capitalization change
-
fee06531...193c4447 - 262 commits from branch
Thanks @aqualls, the changes look good to me. Feel free to pass this on to a maintainer when you're ready.
assigned to @aqualls
unassigned @djadmin
Yay! Assigning to @ohoral now that tests pass. Olena - this merge request tackles a few more instances of incorrect capitalizations of the phrase "merge requests" in the UI, as part of #233449 (closed). I can't make the changes all at once, so I'm landing them a few at a time.
Looks good here, @aqualls! Thanks for tackling this..
mentioned in commit c788db1e
added tw-weight5 twfinished labels
- Resolved by Olena Horal-Koretska
ok, it was merged before I've got to it
added workflowstaging label
added workflowproduction label and removed workflowstaging label
added releasedcandidate label