Count minimal access users in admin area group page [RUN AS-IF-FOSS]
What does this MR do?
Resolves #325729 (closed)
The members count in the group admin page does not include minimal access users because we return all_group_members.count **unless** minimal_access_role_allowed? instead of return all_group_members.count **if** minimal_access_role_allowed?. Additionally the individual group page in the admin area does not show the right count because we use @group.members.size, which doesn't include minimal access users.
all_group_members : https://gitlab.com/gitlab-org/gitlab/-/blob/master/app/models/group.rb#L23
Before:
rendered by app/views/admin/groups/_group.html.haml
rendered by app/views/admin/groups/show.html.haml
After:
Screenshots (strongly suggested)
Does this MR meet the acceptance criteria?
Conformity
-
📋 Does this MR need a changelog?-
I have included a changelog entry. -
I have not included a changelog entry because _____.
-
-
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Related to #325729 (closed)