Can't run DAST scan without repository
What does this MR do?
This adds an error message below the branch selector and changes the selector's "no results" text in the on-demand scans form when a default branch does not exist. The assumption here is that when no default branch exists, then no repository has been created in the project yet and on-demand scans can not be run. The message recommends creating a repository before attempting to run scans.
How to test this?
- Create a blank project without a Git repository.
- Navigate to the on-demand scans form at
/:namespace/:blank_project/-/on_demand_scans/new.
Screenshots (strongly suggested)
| Before | After |
|---|---|
 |
 |
 |
 |
| It's worth noting that it is possible to save scan profiles, even without a branch, but attempting to run it would fail with an API error: |
Does this MR meet the acceptance criteria?
Conformity
-
📋 Does this MR need a changelog?-
I have included a changelog entry. -
I have not included a changelog entry because _____.
-
-
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Related to #324777 (closed)
Edited by Paul Gascou-Vaillancourt