Skip to content

Resolve Follow up on dismiss vulnerability or create issue

What does this MR do?

Cleanup/refactor follow up on #5151 (closed)

Are there points in the code the reviewer needs to double check?

Why was this MR needed?

Some comments from the review of https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/5452 were not addressed due to the lack of time.

Does this MR meet the acceptance criteria?

  • Changelog entry added, if necessary
  • Documentation created/updated
  • API support added
  • Tests added for this feature/bug
  • Conform by the code review guidelines
    • Has been reviewed by a UX Designer
    • Has been reviewed by a Frontend maintainer
    • Has been reviewed by a Backend maintainer
    • Has been reviewed by a Database specialist
  • EE specific content should be in the top level /ee folder
  • Conform by the merge request performance guides
  • Conform by the style guides
  • If you have multiple commits, please combine them into a few logically organized commits by squashing them
  • Internationalization required/considered
  • If paid feature, have we considered GitLab.com plan and how it works for groups and is there a design for promoting it to users who aren't on the correct plan
  • End-to-end tests pass (package-qa manual pipeline job)

What are the relevant issue numbers?

#5919 (closed)

Edited by Olivier Gonzalez

Merge request reports