Skip to content

Fix Assignee dropdown showing assignee(s) twice

What does this MR do?

  • Fixes: double divider and assignee(s) headers on the assignee the issues/merge requests assignees list when visiting for the 2nd time(click edit once, exit the dropdown, then click edit again)

Test locally on GDK

  • Go to any issue or merge request
  • Click edit on assignees - observe.
  • Close assignee dropdown.
  • Click edit on assignee again and notice no duplication of divider/header.

Screenshots (strongly suggested)

before after
Screen_Shot_2021-03-24_at_4.33.28_PM Screen_Shot_2021-03-25_at_3.33.21_PM
Screen_Recording_2021-03-31_at_2.54.32_PM Screen_Recording_2021-03-31_at_2.47.56_PM

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #325991

Edited by Doug Stull

Merge request reports