Policy Editor: switching the custom editor to Source Editor
What does this MR do?
Switches Threat Monitoring Policy editor from custom Monaco implementation to the Source Editor.
Screenshots (strongly suggested)
Page | Before | After |
---|---|---|
Edit Policy | ![]() |
![]() |
Policy List | ![]() |
![]() |
Does this MR meet the acceptance criteria?
Conformity
-
📋 Does this MR need a changelog?-
I have included a changelog entry. -
I have not included a changelog entry because _____.
-
-
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Merge request reports
Activity
added frontend label
2 Warnings ⚠ Please add a merge request type to this merge request. ⚠ This merge request does not refer to an existing milestone. Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
Category Reviewer Maintainer frontend Justin Ho ( @justin_ho
) (UTC+7, 5 hours ahead of@dmishunov
)Savas Vedova ( @svedova
) (UTC+2, same timezone as@dmishunov
)If needed, you can retry the
danger-review
job that generated this comment.Generated by
🚫 DangerEdited by 🤖 GitLab Bot 🤖mentioned in issue #326020 (closed)
added devopsgovern groupsecurity policies sectiondev labels
added 1 commit
- e4cac698 - Switching the custom editor to Source Editor
added 1 commit
- 6038bc97 - Switching the custom editor to Source Editor
added databasereview pending label
added database label
added 1 commit
- bbf42c18 - Switching the custom editor to Source Editor
added 1 commit
- e6657867 - Switching the custom editor to Source Editor
added 1 commit
- 329df4e1 - Switching the custom editor to Source Editor
- Resolved by Miguel Rincon
@aturinske after all I went on and actually converted this one into a more or less proper MR. Do you mind reviewing this one to make sure the things keep working/looking fine and whether we can iterate to a better implementation from here?
requested review from @aturinske
added 313 commits
-
329df4e1...55959477 - 312 commits from branch
master
- 6b9e1b61 - Switching the custom editor to Source Editor
-
329df4e1...55959477 - 312 commits from branch
removed databasereview pending label
removed database label
assigned to @aturinske
- Resolved by Miguel Rincon
- Resolved by Miguel Rincon
- Resolved by Miguel Rincon
- Resolved by Miguel Rincon
- Resolved by Miguel Rincon
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits f8c05de7 and 350fd251
✨ Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 3.12 MB 3.12 MB - 0.0 % mainChunk 1.87 MB 1.87 MB - 0.0 %
Note: We do not have exact data for f8c05de7. So we have used data from: 98678b5b.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.Please look at the full report for more details
Read more about how this report works.
Generated by
🚫 DangerEdited by 🤖 GitLab Bot 🤖
requested review from @mrincon
- Resolved by Alexander Turinske
added UX label
requested review from @andyvolpe
removed review request for @mrincon and @andyvolpe
assigned to @andyvolpe
requested review from @andyvolpe
unassigned @andyvolpe
added 771 commits
-
84de13d0...825cde32 - 768 commits from branch
master
- b7e74c95 - Switching the custom editor to Source Editor
- d2ec1fb3 - Clean up network-policy-editor
- 639c1686 - Update method name to align with Vue standards
Toggle commit list-
84de13d0...825cde32 - 768 commits from branch
requested review from @mrincon
removed review request for @mrincon
mentioned in issue #326746 (closed)
added 293 commits
-
639c1686...f7648c58 - 289 commits from branch
master
- f42183fd - Switching the custom editor to Source Editor
- 808f57df - Clean up network-policy-editor
- a091c6e6 - Update method name to align with Vue standards
- 350fd251 - Add comment for suspect property
Toggle commit list-
639c1686...f7648c58 - 289 commits from branch
requested review from @mrincon
added typemaintenance label
added typefeature label
mentioned in commit 8ada13ae
added workflowstaging label
added workflowcanary label and removed workflowstaging label
added workflowproduction label and removed workflowcanary label
changed milestone to %13.11
added releasedcandidate label
removed typefeature label