Skip to content
Snippets Groups Projects

Policy Editor: switching the custom editor to Source Editor

Merged Denys Mishunov requested to merge threat-monitoring-policy-editor-source-editor into master
All threads resolved!

What does this MR do?

Switches Threat Monitoring Policy editor from custom Monaco implementation to the Source Editor.

Screenshots (strongly suggested)

Page Before After
Edit Policy edit_policy_b edit_policy_a
Policy List drawer_b drawer_a

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Alexander Turinske

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Alexander Turinske
  • Alexander Turinske
  • Alexander Turinske
  • Alexander Turinske approved this merge request

    approved this merge request

  • Alexander Turinske requested review from @mrincon

    requested review from @mrincon

  • Miguel Rincon approved this merge request

    approved this merge request

  • added UX label

  • Miguel Rincon requested review from @andyvolpe

    requested review from @andyvolpe

  • Miguel Rincon removed review request for @mrincon and @andyvolpe

    removed review request for @mrincon and @andyvolpe

  • Miguel Rincon requested review from @andyvolpe

    requested review from @andyvolpe

  • Andy Volpe approved this merge request

    approved this merge request

  • Alexander Turinske added 771 commits

    added 771 commits

    Compare with previous version

  • Alexander Turinske requested review from @mrincon

    requested review from @mrincon

  • Miguel Rincon removed review request for @mrincon

    removed review request for @mrincon

  • mentioned in issue #326746 (closed)

  • Alexander Turinske added 293 commits

    added 293 commits

    Compare with previous version

  • Alexander Turinske requested review from @mrincon

    requested review from @mrincon

  • Miguel Rincon resolved all threads

    resolved all threads

  • merged

  • Miguel Rincon mentioned in commit 8ada13ae

    mentioned in commit 8ada13ae

  • added workflowcanary label and removed workflowstaging label

  • added workflowproduction label and removed workflowcanary label

  • Denys Mishunov changed milestone to %13.11

    changed milestone to %13.11

  • Please register or sign in to reply
    Loading