Reverting a merge request | E2E
This is based on the following testcase: gitlab-org/quality/testcases#1745 (closed)
Merge request reports
Activity
1 Warning This merge request changed files with disabled eslint rules. Please consider fixing them. 1 Message CHANGELOG missing: If you want to create a changelog entry for GitLab FOSS, run the following:
bin/changelog -m 57500 "Reverting a merge request | E2E"
If you want to create a changelog entry for GitLab EE, run the following instead:
bin/changelog --ee -m 57500 "Reverting a merge request | E2E"
If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Disabled eslint rules
The following files have disabled
eslint
rules. Please consider fixing them:app/assets/javascripts/vue_merge_request_widget/components/states/mr_widget_merged.vue
Run the following command for more details
node_modules/.bin/eslint --report-unused-disable-directives --no-inline-config \ 'app/assets/javascripts/vue_merge_request_widget/components/states/mr_widget_merged.vue'
Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
Category Reviewer Maintainer frontend Peter Hegman ( @peterhegman
) (UTC-7, 9 hours behind@tomi
)Olena HK. ( @ohoral
) (UTC+3, 1 hour ahead of@tomi
)QA Zeff Morgan ( @zeffmorgan
) (UTC-4, 6 hours behind@tomi
)Sanad Liaquat ( @sliaquat
) (UTC+5, 3 hours ahead of@tomi
)If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerEdited by 🤖 GitLab Bot 🤖added 243 commits
-
53c3aad6...c3228bff - 236 commits from branch
master
- 6e7a9bf4 - Adding the page objects
- 3109b445 - Adding the test itself
- 96cdbb2e - Apply 3 suggestion(s) to 1 file(s)
- 37d28bac - Adding modal class
- 5a0a2e1b - Apply 2 suggestion(s) to 2 file(s)
- 664add02 - Adding page object modifications
- 1492b9c2 - Adding test coverage for revert
Toggle commit list-
53c3aad6...c3228bff - 236 commits from branch
mentioned in issue gitlab-com/www-gitlab-com#10528 (closed)
added 64 commits
-
1492b9c2...179454bc - 57 commits from branch
master
- c637c834 - Adding the page objects
- 3a6cbc6b - Adding the test itself
- 7d58e388 - Apply 3 suggestion(s) to 1 file(s)
- 6743542b - Adding modal class
- 07092615 - Apply 2 suggestion(s) to 2 file(s)
- 0aaddbb5 - Adding page object modifications
- 03d58885 - Adding test coverage for revert
Toggle commit list-
1492b9c2...179454bc - 57 commits from branch
added 405 commits
Toggle commit listadded Category:Code Review Workflow groupcode review labels
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 3821a02c and b6ad40ae
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 3.12 MB 3.12 MB - 0.0 % mainChunk 1.87 MB 1.87 MB - 0.0 %
Note: We do not have exact data for 3821a02c. So we have used data from: 125ee937.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.Please look at the full report for more details
Read more about how this report works.
Generated by
DangerEdited by 🤖 GitLab Bot 🤖added 243 commits
-
6c1ebe2e...425d63ff - 240 commits from branch
master
- 33f10cb1 - Adding the page objects
- 5f66f489 - Adding modal class
- a58f66d7 - Adding page object modifications
Toggle commit list-
6c1ebe2e...425d63ff - 240 commits from branch
Setting label(s) devopscreate sectiondev based on groupcode review.
added devopscreate sectiondev labels
added 307 commits
-
a58f66d7...dc57225e - 304 commits from branch
master
- e7fc964d - Adding the page objects
- 4c399d2f - Adding modal class
- 1c8765c6 - Adding page object modifications
Toggle commit list-
a58f66d7...dc57225e - 304 commits from branch
- Resolved by Tomislav Nikić
@zeffmorgan & @sliaquat please do a review and merge
requested review from @zeffmorgan and @sliaquat
- Resolved by Sanad Liaquat
- Resolved by Tomislav Nikić
- Resolved by Tomislav Nikić
added 265 commits
-
1c8765c6...3821a02c - 262 commits from branch
master
- be8900f5 - Adding the page objects
- 073d7aa8 - Adding modal class
- b6ad40ae - Adding page object modifications
Toggle commit list-
1c8765c6...3821a02c - 262 commits from branch
added typefeature typemaintenance labels
changed milestone to %13.11
The
package-and-qa
job from pipeline https://gitlab.com/gitlab-org/gitlab/-/pipelines/280621157 triggered https://gitlab.com/gitlab-org/build/omnibus-gitlab-mirror/-/pipelines/280630528 downstream.The
Trigger:qa-test
job from pipeline https://gitlab.com/gitlab-org/build/omnibus-gitlab-mirror/-/pipelines/280630528 triggered https://gitlab.com/gitlab-org/gitlab-qa-mirror/-/pipelines/280656407 downstream.The
gitlab-qa
downstream pipeline failed! .The
package-and-qa
job from pipeline https://gitlab.com/gitlab-org/gitlab/-/pipelines/280621157 triggered https://gitlab.com/gitlab-org/build/omnibus-gitlab-mirror/-/pipelines/280666362 downstream.The
Trigger:qa-test
job from pipeline https://gitlab.com/gitlab-org/build/omnibus-gitlab-mirror/-/pipelines/280666362 triggered https://gitlab.com/gitlab-org/gitlab-qa-mirror/-/pipelines/280697459 downstream.The
gitlab-qa
downstream pipeline failed! .
@tomi LGTM!
mentioned in commit 6d7ab904
added workflowstaging label
added workflowcanary label and removed workflowstaging label
added workflowproduction label and removed workflowcanary label
added releasedcandidate label
mentioned in issue gitlab-com/www-gitlab-com#9487 (closed)
removed typefeature label