Raise and track project destroy errors

What does this MR do?

The project destroy service currently rescues all errors without re-raising them. It does store them as a delete_error on projects however.

This makes it difficult to develop this code because any legitimate bugs leading to errors are not raised as errors.

This also may be hiding errors from sentry errors that may be important to address. For instance this error is in the delete_errors field:

 PG::ForeignKeyViolation: ERROR:  update or delete on table "projects" violates foreign key constraint "fk_rails_2e02bbd1a6" on table "ci_freeze_periods"

                                                                                     +
 DETAIL:  Key (id)=(24575385) is still referenced from table "ci_freeze_periods".

Screenshots (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

• 📋 Does this MR need a changelog?
  • I have included a changelog entry.
  • I have not included a changelog entry because _____.
• Documentation (if required)
• Code review guidelines
• Merge request performance guidelines
• Style guides
• Database guides
• Separation of EE specific content

Availability and Testing

• Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process.
• Tested in all supported browsers
• Informed Infrastructure department of a default or new setting change, if applicable per definition of done

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

• Label as security and @ mention @gitlab-com/gl-security/appsec
• The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
• Security reports checked/validated by a reviewer from the AppSec team