'/projects/:id/repository/compare' supports comparing branches/commits on different projects.
What does this MR do?
This MR allows comparing branches/commits on different projects.
From 13.10 with feature 'compare_repo_dropdown' enabled, it is possible to compare projects on the website (#14615 (closed)) but not using the API.
I've added the parameter 'from_project_id' to the '/projects/:id/repository/compare' endpoint so a different project can be specified. If 'from_project_id' is left out, the endpoint will default to comparing branches/commits on the same project (specified by :id)
It should not be possible to compare to a project you don't have access to, as the function find_project checks if the current user has access to the repository.
Screenshots
Does this MR meet the acceptance criteria?
Conformity
-
📋 Does this MR need a changelog?-
I have included a changelog entry. -
I have not included a changelog entry because _____.
-
-
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. - [ - ] Tested in all supported browsers
-
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team