Skip to content

When REMOVING a user, warn Admin user is part of an on-call schedule

What does this MR do?

Adds a message to the confirmation modal that the user is part of the Oncall-schedule on removing her/him from the group or project

Same when the user is trying to leave a group/project

👀 To check Navigate to Operations/On-call schedules or direct link is your_project/-/oncall_schedules e.g. http://127.0.0.1:3000/gitlab-org/gitlab-shell/-/oncall_schedules => Create schedule=> After you'd be able to create schedule rotations=>Add some user to the rotation than try removing him from the project

Create schedule

2021-04-12_16.06.43

Add rotation

2021-04-12_16.06.59

Go to your_project/-/members and try removing user that is part of the rotations

Screen_Shot_2021-04-13_at_13.15.43

Same you could add your user (as admin) to the on-call schedule rotation and then try leaving a project

Screen_Shot_2021-04-14_at_13.06.45 Note that when action is confirmed admin/user is not prevented from removing user/leaving a project. Rotation update will be triggered - this is yet to be implemented #323631 (closed)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #323627 (closed)

Edited by Olena Horal-Koretska

Merge request reports