Skip to content

Fix N+1 issue in note discussions

Jan Provaznik requested to merge discussions_nplusone into master

What does this MR do?

When merge request discussion is rendered, we render also discussion notes, which triggers extra SQL query when trying to check if note's discussion is resolvable. We can optimize this by passing note's discussion the the Note entity.

Related to #325793 (closed)

Screenshots (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Jan Provaznik

Merge request reports

Loading