Skip to content

Improve the diffs app render queue

Phil Hughes requested to merge ph/321691/improveDiffsRenderingQueue into master

What does this MR do?

Improves how the rendering queue for the diffs app works by checking the idle time we have in the requestIdleCallback callback.

In this we also change the logic around renderIt to render the first 3 files quickly and then put the rest into the queue. This allows us to render quickly without blocking the browser a lot.

Screenshots (strongly suggested)

Before After
Screenshot_2021-03-24_at_13.43.16 Screenshot_2021-03-24_at_13.43.33

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Closes #321691 (closed)

Edited by André Luís

Merge request reports